From 0bd306773d2a9459b3ab88304123c894297c7f9c Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 12 Mar 2026 01:22:06 +0000
Subject: [PATCH] Replace redundant chunked tests with targeted non-range
 pause/resume test

Remove TestFetcher_DownloadChunkedContinue (redundant with existing tests).
Replace TestFetcher_DownloadChunkedNotExceedSize with
TestFetcher_DownloadNoRangePauseResume which specifically targets the bug:
- Documents the root cause (non-range resume writes at accumulated offset
  instead of byte 0)
- Asserts downloaded file size does not exceed source file size (the exact
  bug symptom from the issue)
- Verifies file integrity via MD5

Co-authored-by: monkeyWie <13160176+monkeyWie@users.noreply.github.com>
---
 internal/protocol/http/fetcher_test.go | 36 ++++++++++++++++----------
 1 file changed, 23 insertions(+), 13 deletions(-)

diff --git a/internal/protocol/http/fetcher_test.go b/internal/protocol/http/fetcher_test.go
index 377266d5..c4950210 100644
--- a/internal/protocol/http/fetcher_test.go
+++ b/internal/protocol/http/fetcher_test.go
@@ -307,19 +307,14 @@ func TestFetcher_DownloadChunked(t *testing.T) {
 	downloadNormal(listener, 2, t)
 }
 
-func TestFetcher_DownloadChunkedContinue(t *testing.T) {
-	listener := test.StartTestCustomServer()
-	defer listener.Close()
-
-	downloadContinue(listener, 1, t)
-}
-
-// TestFetcher_DownloadChunkedNotExceedSize verifies that when a server doesn't
-// return Content-Length (chunked transfer, no Range support), the download
-// properly handles pause/resume without accumulating extra bytes.
-// This simulates the real-world bug where servers like GitHub's zip downloads
-// don't return Content-Length.
-func TestFetcher_DownloadChunkedNotExceedSize(t *testing.T) {
+// TestFetcher_DownloadNoRangePauseResume targets a specific bug where pausing
+// and resuming a download from a server that doesn't return Content-Length
+// (and doesn't support Range) causes the downloaded file to grow beyond the
+// actual file size. Root cause: on resume the server resends from byte 0, but
+// the old code wrote at the previously accumulated offset, appending a second
+// copy instead of overwriting. The fix resets the write offset on each non-range
+// retry so data is always written from the beginning.
+func TestFetcher_DownloadNoRangePauseResume(t *testing.T) {
 	listener := test.StartTestCustomServer()
 	defer listener.Close()
 
@@ -342,6 +337,21 @@ func TestFetcher_DownloadChunkedNotExceedSize(t *testing.T) {
 		t.Fatal(err)
 	}
 
+	// The critical assertion: the downloaded file must not be larger than
+	// the source file. Before the fix, each resume appended extra data,
+	// causing the file to exceed the actual size (the bug shown in the issue).
+	downloadInfo, err := os.Stat(test.DownloadFile)
+	if err != nil {
+		t.Fatal(err)
+	}
+	sourceInfo, err := os.Stat(test.BuildFile)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if downloadInfo.Size() > sourceInfo.Size() {
+		t.Errorf("Downloaded file size %d exceeds source file size %d", downloadInfo.Size(), sourceInfo.Size())
+	}
+
 	want := test.FileMd5(test.BuildFile)
 	got := test.FileMd5(test.DownloadFile)
 	if want != got {