diff --git a/ui/flutter/lib/features/extensions/application/extensions_controller.dart b/ui/flutter/lib/features/extensions/application/extensions_controller.dart index 263b2c4c..110af4ce 100644 --- a/ui/flutter/lib/features/extensions/application/extensions_controller.dart +++ b/ui/flutter/lib/features/extensions/application/extensions_controller.dart @@ -49,7 +49,6 @@ class ExtensionsState { this.loadingMoreStore = false, this.busyExtensionIds = const {}, this.devMode = false, - this.updateCheckFailed = false, }); final List installedExtensions; @@ -64,7 +63,6 @@ class ExtensionsState { final bool loadingMoreStore; final Set busyExtensionIds; final bool devMode; - final bool updateCheckFailed; UnmodifiableMapView get installedMap => UnmodifiableMapView({for (final ext in installedExtensions) ext.identity: ext}); @@ -102,7 +100,6 @@ class ExtensionsState { bool? loadingMoreStore, Set? busyExtensionIds, bool? devMode, - bool? updateCheckFailed, }) { return ExtensionsState( installedExtensions: installedExtensions ?? this.installedExtensions, @@ -117,7 +114,6 @@ class ExtensionsState { loadingMoreStore: loadingMoreStore ?? this.loadingMoreStore, busyExtensionIds: busyExtensionIds ?? this.busyExtensionIds, devMode: devMode ?? this.devMode, - updateCheckFailed: updateCheckFailed ?? this.updateCheckFailed, ); } } @@ -263,23 +259,15 @@ class ExtensionsController extends AsyncNotifier { Future checkUpdate() async { final flags = {}; - var failed = false; for (final ext in _current.installedExtensions) { try { final resp = await ref.read(gopeedServiceProvider).upgradeCheckExtension(ext.identity); if (resp.newVersion.isNotEmpty) { flags[ext.identity] = resp.newVersion; } - } catch (_) { - failed = true; - } + } catch (_) {} } - state = AsyncValue.data( - _current.copyWith( - updateFlags: flags, - updateCheckFailed: failed && _current.installedExtensions.isNotEmpty, - ), - ); + state = AsyncValue.data(_current.copyWith(updateFlags: flags)); } void tryOpenDevMode() { diff --git a/ui/flutter/lib/features/extensions/presentation/pages/extensions_page.dart b/ui/flutter/lib/features/extensions/presentation/pages/extensions_page.dart index 330b2869..379056af 100644 --- a/ui/flutter/lib/features/extensions/presentation/pages/extensions_page.dart +++ b/ui/flutter/lib/features/extensions/presentation/pages/extensions_page.dart @@ -107,12 +107,6 @@ class _ExtensionsPageState extends ConsumerState { }); } final stateAsync = ref.watch(extensionsControllerProvider); - ref.listen(extensionsControllerProvider, (previous, next) { - final failed = next.value?.updateCheckFailed ?? false; - if (failed && previous?.value?.updateCheckFailed != true) { - showAppToast(context, context.l10n.extensionUpdateCheckFailed); - } - }); final body = Stack( children: [ ColoredBox( diff --git a/ui/flutter/lib/l10n/app_en.arb b/ui/flutter/lib/l10n/app_en.arb index 0cb61f11..5ad3aacc 100644 --- a/ui/flutter/lib/l10n/app_en.arb +++ b/ui/flutter/lib/l10n/app_en.arb @@ -120,7 +120,6 @@ } }, "extensionUpdateSuccess": "Updated successfully", - "extensionUpdateCheckFailed": "Failed to check for updates. Please check your network", "extensionDelete": "Delete Extension", "extensionAlreadyLatest": "It's already the latest version", "extensionFind": "Find Extensions", diff --git a/ui/flutter/lib/l10n/app_zh.arb b/ui/flutter/lib/l10n/app_zh.arb index 6d4e91fc..c67677e0 100644 --- a/ui/flutter/lib/l10n/app_zh.arb +++ b/ui/flutter/lib/l10n/app_zh.arb @@ -106,7 +106,6 @@ "extensionInstallSuccess": "安装成功", "extensionUpdateConfirm": "确定将“{name}”更新到最新版本吗?", "extensionUpdateSuccess": "更新成功", - "extensionUpdateCheckFailed": "检查更新失败,请检查网络后重试", "extensionDelete": "删除扩展", "extensionAlreadyLatest": "已经是最新版本", "extensionFind": "获取扩展",