fix: non-range HTTP downloaded bytes exceeding total file size (#1317)

internal/protocol/http/fetcher_test.go

@@ -299,6 +299,53 @@ func TestFetcher_DownloadContinue(t *testing.T) {
 	downloadContinue(listener, 16, t)
 }
 
+func TestFetcher_DownloadContinue_NoRangeRestart(t *testing.T) {
+	listener := test.StartTestNoRangeSlowServer(time.Millisecond)
+	defer listener.Close()
+
+	fetcher := downloadReady(listener, 4, t)
+	if err := fetcher.Start(); err != nil {
+		t.Fatal(err)
+	}
+
+	time.Sleep(20 * time.Millisecond)
+
+	stats := fetcher.Stats().(*http.Stats)
+	if len(stats.Connections) != 1 {
+		t.Fatalf("expected a single non-range connection, got %d", len(stats.Connections))
+	}
+	if stats.Connections[0].Downloaded <= 0 || stats.Connections[0].Downloaded >= test.BuildSize {
+		t.Fatalf("expected partial download before pause, got %d", stats.Connections[0].Downloaded)
+	}
+
+	if err := fetcher.Pause(); err != nil {
+		t.Fatal(err)
+	}
+	if err := fetcher.Start(); err != nil {
+		t.Fatal(err)
+	}
+	if err := fetcher.Wait(); err != nil {
+		t.Fatal(err)
+	}
+
+	finalStats := fetcher.Stats().(*http.Stats)
+	if len(finalStats.Connections) != 1 {
+		t.Fatalf("expected a single non-range connection after resume, got %d", len(finalStats.Connections))
+	}
+	if finalStats.Connections[0].Downloaded != test.BuildSize {
+		t.Fatalf("downloaded bytes should restart cleanly: got %d, want %d", finalStats.Connections[0].Downloaded, test.BuildSize)
+	}
+	if total := fetcher.Progress().TotalDownloaded(); total != test.BuildSize {
+		t.Fatalf("progress total = %d, want %d", total, test.BuildSize)
+	}
+
+	want := test.FileMd5(test.BuildFile)
+	got := test.FileMd5(test.DownloadFile)
+	if want != got {
+		t.Errorf("Download() got = %v, want %v", got, want)
+	}
+}
+
 func TestFetcher_DownloadChunked(t *testing.T) {
 	listener := test.StartTestCustomServer()
 	defer listener.Close()
@@ -1384,8 +1431,8 @@ func TestFetcher_Patch_Extra(t *testing.T) {
 			Method: "POST", // Update method
 			// Body is empty, should NOT update
 			Header: map[string]string{
-				"X-Custom":   "modified", // Overwrite existing
-				"X-New":      "added",    // Add new
+				"X-Custom": "modified", // Overwrite existing
+				"X-New":    "added",    // Add new
 				// Authorization is not in patch, should remain
 			},
 		},