feat: enhance deep link handling for install extensions (#1249)

pkg/download/extension.go

@@ -3,6 +3,14 @@ package download
 import (
 	"encoding/json"
 	"fmt"
+	"io"
+	"os"
+	"path"
+	"path/filepath"
+	"strconv"
+	"strings"
+	"time"
+
 	"github.com/GopeedLab/gopeed/internal/logger"
 	"github.com/GopeedLab/gopeed/pkg/base"
 	"github.com/GopeedLab/gopeed/pkg/download/engine"
@@ -12,13 +20,6 @@ import (
 	"github.com/dop251/goja"
 	"github.com/go-git/go-git/v5"
 	"github.com/go-git/go-git/v5/plumbing/transport"
-	"io"
-	"os"
-	"path"
-	"path/filepath"
-	"strconv"
-	"strings"
-	"time"
 )
 
 var (
@@ -200,10 +201,14 @@ func (d *Downloader) fetchExtensionByGit(url string, handler func(tempExtPath st
 		subPath = pathArr[1]
 	}
 
-	tempExtDir := filepath.Join(d.cfg.StorageDir, tempExtensionsDir, projectPath)
-	if err := util.RmAndMkDirAll(tempExtDir); err != nil {
+	// Use unique suffix to avoid concurrent conflicts when multiple git operations
+	// target the same extension (e.g., install and update check happening simultaneously)
+	tempExtDir := filepath.Join(d.cfg.StorageDir, tempExtensionsDir, fmt.Sprintf("%s_%d", projectPath, time.Now().UnixNano()))
+	if err := os.MkdirAll(tempExtDir, 0755); err != nil {
 		return nil, err
 	}
+	defer os.RemoveAll(tempExtDir)
+
 	proxyOptions := transport.ProxyOptions{}
 	proxyUrl := d.cfg.DownloaderStoreConfig.Proxy.ToUrl()
 	if proxyUrl != nil {
@@ -220,7 +225,6 @@ func (d *Downloader) fetchExtensionByGit(url string, handler func(tempExtPath st
 	}); err != nil {
 		return nil, err
 	}
-	defer os.RemoveAll(tempExtDir)
 
 	return handler(filepath.Join(tempExtDir, subPath), false)
 }

pkg/util/path.go

@@ -141,17 +141,6 @@ func CopyDir(source string, target string, excludeDir ...string) error {
 	return nil
 }
 
-// RmAndMkDirAll remove and create directory, if the directory already exists, it will be overwritten.
-func RmAndMkDirAll(path string) error {
-	if err := os.RemoveAll(path); err != nil {
-		return err
-	}
-	if err := os.MkdirAll(path, 0755); err != nil {
-		return err
-	}
-	return nil
-}
-
 // copy file, if the target file already exists, it will be overwritten.
 func copyForce(source string, target string) error {
 	sourceFile, err := os.Open(source)