From ba84a04a434bc65bebddb2fac2f9b8cec68f8c99 Mon Sep 17 00:00:00 2001 From: WuFeng Date: Thu, 8 Oct 2026 16:31:16 +0800 Subject: [PATCH] fix(settings): use Save as the primary label on settings form dialogs (#1571) --- .../presentation/widgets/download_categories_setting.dart | 2 +- .../settings/presentation/widgets/settings_list_editor.dart | 4 ++-- ui/flutter/test/widget_test.dart | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/flutter/lib/features/settings/presentation/widgets/download_categories_setting.dart b/ui/flutter/lib/features/settings/presentation/widgets/download_categories_setting.dart index 8c3c6cf6..dd0a40cb 100644 --- a/ui/flutter/lib/features/settings/presentation/widgets/download_categories_setting.dart +++ b/ui/flutter/lib/features/settings/presentation/widgets/download_categories_setting.dart @@ -201,7 +201,7 @@ Future showDownloadCategoryDialog( onPressed: () => shad.closeOverlay(dialogContext), child: Text(dialogContext.l10n.cancel), ), - AppPrimaryButton(onPressed: submit, child: Text(dialogContext.l10n.confirm)), + AppPrimaryButton(onPressed: submit, child: Text(dialogContext.l10n.save)), ], ); }, diff --git a/ui/flutter/lib/features/settings/presentation/widgets/settings_list_editor.dart b/ui/flutter/lib/features/settings/presentation/widgets/settings_list_editor.dart index 58b325ae..d64cf360 100644 --- a/ui/flutter/lib/features/settings/presentation/widgets/settings_list_editor.dart +++ b/ui/flutter/lib/features/settings/presentation/widgets/settings_list_editor.dart @@ -234,7 +234,7 @@ Future showTextSettingDialog( } shad.closeOverlay(dialogContext, controller.text.trim()); }, - child: Text(dialogContext.l10n.confirm), + child: Text(dialogContext.l10n.save), ), ], ); @@ -321,7 +321,7 @@ Future showGithubMirrorDialog(BuildContext context, {GithubM } shad.closeOverlay(dialogContext, GithubMirrorDraft(type: selectedType, url: value)); }, - child: Text(dialogContext.l10n.confirm), + child: Text(dialogContext.l10n.save), ), ], ); diff --git a/ui/flutter/test/widget_test.dart b/ui/flutter/test/widget_test.dart index c9427a11..3365a275 100644 --- a/ui/flutter/test/widget_test.dart +++ b/ui/flutter/test/widget_test.dart @@ -2480,7 +2480,7 @@ void main() { expect(find.text('%date% — Full date (YYYY-MM-DD)'), findsOneWidget); await tester.tap(find.byKey(const ValueKey('path-placeholder-%date%'))); await tester.pumpAndSettle(); - await tester.tap(find.text('Confirm')); + await tester.tap(find.text('Save')); await tester.pumpAndSettle(); expect(find.text('归档'), findsOneWidget);