fix: decode URL-encoded filename from contentDisposition header (#1099)

pkg/util/url.go

@@ -56,3 +56,13 @@ func ProxyUrlToHandler(proxyUrl *url.URL) func(*http.Request) (*url.URL, error)
 	}
 	return http.ProxyURL(proxyUrl)
 }
+
+// TryUrlQueryUnescape tries to unescape a URL-encoded string.
+//
+// If unescaping fails, it returns the original string.
+func TryUrlQueryUnescape(s string) string {
+	if decoded, err := url.QueryUnescape(s); err == nil {
+		return decoded
+	}
+	return s
+}

pkg/util/url_test.go

@@ -128,3 +128,24 @@ func TestParseDataUri(t *testing.T) {
 		})
 	}
 }
+
+func TestTryURLDecode(t *testing.T) {
+	tests := []struct {
+		input    string
+		expected string
+	}{
+		{"normal.txt", "normal.txt"},
+		{"%E7%8F%80%E5%B0%94%E8%AF%BA.zip", "珀尔诺.zip"},
+		{"hello%20world.txt", "hello world.txt"},
+		{"bad%2-text", "bad%2-text"},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.input, func(t *testing.T) {
+			got := TryUrlQueryUnescape(tt.input)
+			if got != tt.expected {
+				t.Errorf("TryUrlQueryUnescape(%q) = %q, want %q", tt.input, got, tt.expected)
+			}
+		})
+	}
+}