refactor(downloader): remove opts parameter from Resolve (#1595)

This commit is contained in:
Levi authored and GitHub committed 2026-10-19 21:40:57 +08:00
1 parent 5462b14705
commit de65149b29
45 files changed
+1589 -384

No files matched your search

+2 -2
View File
@@ -26,7 +26,7 @@ func Info(w http.ResponseWriter, r *http.Request) {
func Resolve(w http.ResponseWriter, r *http.Request) {
var req model.ResolveTask
if ReadJson(r, w, &req) {
rr, err := Downloader.Resolve(req.Req, req.Opts)
rr, err := Downloader.Resolve(req.Req)
if err != nil {
WriteJson(w, model.NewErrorResult(err.Error()))
return
@@ -82,7 +82,7 @@ func PatchTask(w http.ResponseWriter, r *http.Request) {
return
}
var req model.ResolveTask
var req model.PatchTask
if ReadJson(r, w, &req) {
if err := Downloader.Patch(taskId, req.Req, req.Opts); err != nil {
if err == download.ErrTaskNotFound {
+4
View File
@@ -3,6 +3,10 @@ package model
import "github.com/GopeedLab/gopeed/pkg/base"
type ResolveTask struct {
Req *base.Request `json:"req"`
}
type PatchTask struct {
Req *base.Request `json:"req"`
Opts *base.Options `json:"opts"`
}
+5 -5
View File
@@ -55,8 +55,7 @@ var (
},
}
resolveReq = &model.ResolveTask{
Req: taskReq,
Opts: createOpts,
Req: taskReq,
}
createReq = &model.CreateTask{
Req: taskReq,
@@ -105,7 +104,8 @@ func TestCreateTask(t *testing.T) {
})
taskId := httpRequestCheckOk[string](http.MethodPost, "/api/v1/tasks", &model.CreateTask{
Rid: resp.ID,
Rid: resp.ID,
Opts: createOpts,
})
if taskId == "" {
t.Fatal("create task failed")
@@ -295,7 +295,7 @@ func TestPatchTask(t *testing.T) {
time.Sleep(time.Millisecond * 100)
// Patch the task with new labels
patchReq := &model.ResolveTask{
patchReq := &model.PatchTask{
Req: &base.Request{
Labels: map[string]string{
"patched": "true",
@@ -322,7 +322,7 @@ func TestPatchTask(t *testing.T) {
func TestPatchTaskNotFound(t *testing.T) {
doTest(func() {
// Try to patch a non-existent task
patchReq := &model.ResolveTask{
patchReq := &model.PatchTask{
Req: &base.Request{
Labels: map[string]string{
"test": "value",