test(logging): add logtest.NewLogger (#1300)

Return a `Logger` and its recording `Handler` together, so tests no longer need the two-line setup.

Stacked on https://gitea.com/gitea/runner/pulls/1295.

Assisted-by: Codet
Co-authored-by: bircni <[email protected]>
Reviewed-on: https://gitea.com/gitea/runner/pulls/1300
Reviewed-by: bircni <[email protected]>

act/common/logging/logging_test.go

@@ -92,8 +92,7 @@ func frameOf(t *testing.T, pc uintptr) runtime.Frame {
 }
 
 func TestCallerPC(t *testing.T) {
-	h := logtest.New()
-	l := logging.New(h)
+	l, h := logtest.NewLogger()
 	l.Infof("method")
 	l.Info("method")
 	for _, r := range h.AllRecords() {

act/common/logging/logtest/logtest.go

@@ -29,6 +29,12 @@ func New() *Handler {
 	return NewWithLevel(logging.LevelInfo)
 }
 
+// NewLogger returns a Logger writing to a new Handler from New, and that Handler.
+func NewLogger() (*logging.Logger, *Handler) {
+	h := New()
+	return logging.New(h), h
+}
+
 func NewWithLevel(minLevel logging.Level) *Handler {
 	return &Handler{store: &store{}, minLevel: minLevel}
 }