mirror of
https://gitea.com/gitea/runner.git
synced 2026-11-11 10:24:09 +00:00
fix!: remove the dbfs log workaround and require Gitea 1.26.2 (#1395)
Gitea 1.26.2 finalizes logs on an empty `UpdateLog` with `NoMore` (https://github.com/go-gitea/gitea/pull/37687), so the sentinel row is no longer needed. On older servers, the final log of most jobs would never be archived and stays in `dbfs_data`, so this raises the minimum Gitea version. It lives in `ver.MinGiteaVersion`, which the error for servers without `Declare` now names. Fixes: https://gitea.com/gitea/runner/issues/953 Co-authored-by: silverwind <[email protected]> Reviewed-on: https://gitea.com/gitea/runner/pulls/1395 Reviewed-by: silverwind <[email protected]> Co-authored-by: bircni <[email protected]>
This commit is contained in:
1 parent
c59caa9689
commit
84c0fcd1fa
6 files changed
+6
-20
No files matched your search
@@ -355,7 +355,7 @@ func TestReporter_StateNotifyFlush(t *testing.T) {
|
||||
})
|
||||
}
|
||||
|
||||
func TestReporter_CloseAlwaysSendsRowsWithNoMore(t *testing.T) {
|
||||
func TestReporter_CloseFinalizesLogWithoutRows(t *testing.T) {
|
||||
var lastReq atomic.Pointer[runnerv1.UpdateLogRequest]
|
||||
var noMoreCalls atomic.Int64
|
||||
|
||||
@@ -400,7 +400,7 @@ func TestReporter_CloseAlwaysSendsRowsWithNoMore(t *testing.T) {
|
||||
final := lastReq.Load()
|
||||
require.NotNil(t, final)
|
||||
assert.True(t, final.NoMore, "final UpdateLog must carry NoMore=true")
|
||||
assert.NotEmpty(t, final.Rows, "final UpdateLog must carry at least one row")
|
||||
assert.Empty(t, final.Rows, "a job without output must not get a log row")
|
||||
}
|
||||
|
||||
func TestReporter_StateHeartbeat(t *testing.T) {
|
||||
|
||||
Reference in new issue
Block a user