$GITHUB_PATH support (#566)

* Regression in the .golangci.yml file

* This looks like an even better fix to #451

The previous solution only prevented the `starting container process caused "exec: \"bash\"`
error when someone added an "extra" path in the workflow using `::add-path`

* Add support for >> $GITHUB_PATH

* The newRunCommand has too high cyclomatic complexity

* Add "linux/arm64" to new test

* The cyclop linter was complaining so I extracted some funcs

* Close some readers

* Fix typo

* fix: add missing composite function

* Fix regress from merging

* Keep the error messages as is

* consolidate with master

* Close the tar reader on defer

* New way to get ContainerWorkdir

* Remove arch from runner test

* Separate the UpdateFromEnv and UpdateFromPath

Co-authored-by: hackercat <[email protected]>
This commit is contained in:
Torbjørn Vatnandhackercat authored and GitHub committed 2021-05-06 13:30:12 +00:00
1 parent 8153dc92e5
commit 92eec3a526
8 files changed
+234 -135

No files matched your search

+1
View File
@@ -145,6 +145,7 @@ func readEnvs(path string, envs map[string]string) bool {
return false
}
//nolint:gocyclo
func newRunCommand(ctx context.Context, input *Input) func(*cobra.Command, []string) error {
return func(cmd *cobra.Command, args []string) error {
log.Debugf("Loading environment from %s", input.Envfile())