fix: stop host teardown from deleting a workdir it never created (#1409)

Host jobs run in a per-job directory under `host.workdir_parent`, which teardown removes. Teardown also deleted `<container.workdir_parent>/<owner>/<repo>`, a path host jobs never create. With an empty parent and no repository that was the filesystem root, and any existing directory at that path was deleted although the job never used it.

This removes that delete instead of guarding it, so teardown only removes what the job created.

---------

Co-authored-by: silverwind <[email protected]>
Reviewed-on: https://gitea.com/gitea/runner/pulls/1409
Reviewed-by: bircni <[email protected]>
Co-authored-by: clintlmartin <[email protected]>

act/container/host_environment_test.go

@@ -158,27 +158,12 @@ func TestHostEnvironmentAllocatePTY(t *testing.T) {
 }
 
 func TestHostEnvironmentRemoveWorkdir(t *testing.T) {
-	for name, owned := range map[string]bool{"preserves caller workdir": false, "cleans owned workdir": true} {
-		t.Run(name, func(t *testing.T) {
-			miscRoot, workdir := t.TempDir(), t.TempDir()
-			e := &HostEnvironment{
-				Path:         filepath.Join(miscRoot, "hostexecutor"),
-				Workdir:      workdir,
-				CleanWorkdir: owned,
-				Root:         miscRoot,
-			}
-			require.NoError(t, os.MkdirAll(e.Path, 0o700))
-			require.NoError(t, os.MkdirAll(filepath.Join(miscRoot, "tmp"), 0o700))
-			require.NoError(t, e.Remove()(t.Context()))
-			assert.NoDirExists(t, miscRoot)
-			_, err := os.Stat(workdir)
-			if owned {
-				assert.ErrorIs(t, err, os.ErrNotExist)
-			} else {
-				require.NoError(t, err)
-			}
-		})
-	}
+	miscRoot, workdir := t.TempDir(), t.TempDir()
+	e := &HostEnvironment{Path: filepath.Join(miscRoot, "hostexecutor"), Workdir: workdir, Root: miscRoot}
+	require.NoError(t, os.MkdirAll(e.Path, 0o700))
+	require.NoError(t, e.Remove()(t.Context()))
+	assert.NoDirExists(t, miscRoot)
+	assert.DirExists(t, workdir)
 }
 
 func TestRemoveAllWithContextDoesNotHangOnStuckDelete(t *testing.T) {