refactor: remove dead code and consolidate tests (#1335)

Removes dead code and redundant logic and consolidates tests, so there is less to read and maintain. No behavior change.

1. **act/runner**: inline single-use wrappers, compile regexes once instead of per call, embed the trampoline as a string, drop the unused legacy result of `parseActionCommand`
2. **act/container**: `sanitizeConfig` and `mergeContainerConfigs` stop returning the configs they already mutate in place, drop never-set option fields and the unused `user` parameter of `ExecWithCmdLine`
3. **act/common and cache server**: drop the unused `Trace`/`Tracef` loggers and the short SHA of `FindGitRevision`, `RegisterJob` releases through `RevokeJob`
4. **daemon, poller and reporter**: one shutdown wait for both poll modes, drop an unreachable fetch timeout branch, guard the reporter's last report time with its existing lock instead of an atomic
5. **build**: drop unused Makefile and release workflow variables, collapse the goreleaser ignore list to the same build targets
6. **tests**: fold near-duplicate tests into tables with shared setup

Throughout, hand-rolled logic gives way to `cmp.Or`, `strings.Cut`, `slices` and `min`/`max`.

Reviewed-on: https://gitea.com/gitea/runner/pulls/1335
Reviewed-by: bircni <[email protected]>
Co-authored-by: silverwind <[email protected]>

internal/pkg/labels/labels.go

@@ -5,6 +5,7 @@ package labels
 
 import (
 	"errors"
+	"slices"
 	"strings"
 )
 
@@ -31,17 +32,10 @@ func Parse(str string) (*Label, error) {
 		return nil, errors.New("empty label")
 	}
 
-	splits := strings.SplitN(str, ":", 3)
-	label := &Label{
-		Name:   splits[0],
-		Schema: SchemeHost,
-		Arg:    "",
-	}
-	if len(splits) >= 2 {
-		label.Schema = splits[1]
-	}
-	if len(splits) >= 3 {
-		label.Arg = splits[2]
+	name, remainder, hasSchema := strings.Cut(str, ":")
+	label := &Label{Name: name, Schema: SchemeHost}
+	if hasSchema {
+		label.Schema, label.Arg, _ = strings.Cut(remainder, ":")
 	}
 	kubernetes := label.Schema == SchemeKubernetes && strings.HasPrefix(label.Arg, "//") && len(label.Arg) > 2
 	if label.Schema != SchemeHost && label.Schema != SchemeDocker && !kubernetes {
@@ -58,12 +52,7 @@ func Parse(str string) (*Label, error) {
 type Labels []*Label
 
 func (l Labels) RequireDocker() bool {
-	for _, label := range l {
-		if label.Schema == SchemeDocker {
-			return true
-		}
-	}
-	return false
+	return slices.ContainsFunc(l, func(label *Label) bool { return label.Schema == SchemeDocker })
 }
 
 // PickPlatform returns the platform of the first runs-on entry this runner has a label for, or "".

internal/pkg/labels/labels_test.go

@@ -11,67 +11,20 @@ import (
 
 func TestParse(t *testing.T) {
 	tests := []struct {
-		args    string
-		want    *Label
-		wantErr bool
+		args string
+		want *Label
 	}{
-		{
-			args: "ubuntu:docker://node:18",
-			want: &Label{
-				Name:   "ubuntu",
-				Schema: "docker",
-				Arg:    "//node:18",
-			},
-			wantErr: false,
-		},
-		{
-			args: "ubuntu:host",
-			want: &Label{
-				Name:   "ubuntu",
-				Schema: "host",
-				Arg:    "",
-			},
-			wantErr: false,
-		},
-		{
-			args: "ubuntu",
-			want: &Label{
-				Name:   "ubuntu",
-				Schema: "host",
-				Arg:    "",
-			},
-			wantErr: false,
-		},
-		{
-			args: "pool:e57e18d4-10d4-406f-93bf-60f127221bdd",
-			want: &Label{
-				Name:   "pool:e57e18d4-10d4-406f-93bf-60f127221bdd",
-				Schema: "host",
-				Arg:    "",
-				Opaque: true,
-			},
-			wantErr: false,
-		},
-		{
-			args: "ubuntu:vm:ubuntu-18.04",
-			want: &Label{
-				Name:   "ubuntu:vm:ubuntu-18.04",
-				Schema: "host",
-				Arg:    "",
-				Opaque: true,
-			},
-			wantErr: false,
-		},
-		{
-			args:    "",
-			want:    nil,
-			wantErr: true,
-		},
+		{"ubuntu:docker://node:18", &Label{Name: "ubuntu", Schema: "docker", Arg: "//node:18"}},
+		{"ubuntu:host", &Label{Name: "ubuntu", Schema: "host"}},
+		{"ubuntu", &Label{Name: "ubuntu", Schema: "host"}},
+		{"pool:e57e18d4-10d4-406f-93bf-60f127221bdd", &Label{Name: "pool:e57e18d4-10d4-406f-93bf-60f127221bdd", Schema: "host", Opaque: true}},
+		{"ubuntu:vm:ubuntu-18.04", &Label{Name: "ubuntu:vm:ubuntu-18.04", Schema: "host", Opaque: true}},
+		{"", nil},
 	}
 	for _, tt := range tests {
 		t.Run(tt.args, func(t *testing.T) {
 			got, err := Parse(tt.args)
-			if tt.wantErr {
+			if tt.want == nil {
 				require.Error(t, err)
 				return
 			}
@@ -81,7 +34,6 @@ func TestParse(t *testing.T) {
 	}
 }
 
-// mustParse parses the given label strings, failing the test on any error.
 func mustParse(t *testing.T, strs ...string) Labels {
 	t.Helper()
 	ls := make(Labels, 0, len(strs))
@@ -157,7 +109,6 @@ func TestToStrings(t *testing.T) {
 	}, ls.ToStrings())
 }
 
-// a colon-containing name must survive a write to and read back from the .runner file
 func TestOpaqueLabelRoundTrip(t *testing.T) {
 	const raw = "pool:e57e18d4-10d4-406f-93bf-60f127221bdd"