refactor: remove dead code and consolidate tests (#1335)

Removes dead code and redundant logic and consolidates tests, so there is less to read and maintain. No behavior change.

1. **act/runner**: inline single-use wrappers, compile regexes once instead of per call, embed the trampoline as a string, drop the unused legacy result of `parseActionCommand`
2. **act/container**: `sanitizeConfig` and `mergeContainerConfigs` stop returning the configs they already mutate in place, drop never-set option fields and the unused `user` parameter of `ExecWithCmdLine`
3. **act/common and cache server**: drop the unused `Trace`/`Tracef` loggers and the short SHA of `FindGitRevision`, `RegisterJob` releases through `RevokeJob`
4. **daemon, poller and reporter**: one shutdown wait for both poll modes, drop an unreachable fetch timeout branch, guard the reporter's last report time with its existing lock instead of an atomic
5. **build**: drop unused Makefile and release workflow variables, collapse the goreleaser ignore list to the same build targets
6. **tests**: fold near-duplicate tests into tables with shared setup

Throughout, hand-rolled logic gives way to `cmp.Or`, `strings.Cut`, `slices` and `min`/`max`.

Reviewed-on: https://gitea.com/gitea/runner/pulls/1335
Reviewed-by: bircni <[email protected]>
Co-authored-by: silverwind <[email protected]>

internal/pkg/lock/lock_test.go

@@ -6,49 +6,26 @@
 package lock
 
 import (
-	"errors"
 	"path/filepath"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestTryLock(t *testing.T) {
 	runnerFile := filepath.Join(t.TempDir(), ".runner")
 
-	release, err := TryLock(runnerFile)
-	if err != nil {
-		t.Fatalf("first TryLock failed: %v", err)
-	}
-
-	// A second lock on the same file must be refused while the first is held.
-	if _, err := TryLock(runnerFile); !errors.Is(err, ErrLocked) {
-		t.Fatalf("second TryLock: want ErrLocked, got %v", err)
-	}
-
-	if err := release(); err != nil {
-		t.Fatalf("release failed: %v", err)
-	}
-
-	// After release the lock is available again.
-	release2, err := TryLock(runnerFile)
-	if err != nil {
-		t.Fatalf("TryLock after release failed: %v", err)
-	}
-	if err := release2(); err != nil {
-		t.Fatalf("second release failed: %v", err)
+	for range 2 {
+		release, err := TryLock(runnerFile)
+		require.NoError(t, err)
+		_, err = TryLock(runnerFile)
+		require.ErrorIs(t, err, ErrLocked)
+		require.NoError(t, release())
 	}
 }
 
-// TestTryLockUncreatable ensures a lock file that cannot be created reports a
-// non-ErrLocked error, so callers can tell "already locked by another process"
-// apart from "couldn't lock" and degrade gracefully (e.g. a read-only mount).
 func TestTryLockUncreatable(t *testing.T) {
-	runnerFile := filepath.Join(t.TempDir(), "missing-dir", ".runner")
-
-	_, err := TryLock(runnerFile)
-	if err == nil {
-		t.Fatal("TryLock on an uncreatable lock file: want error, got nil")
-	}
-	if errors.Is(err, ErrLocked) {
-		t.Fatal("TryLock on an uncreatable lock file: want non-ErrLocked error, got ErrLocked")
-	}
+	_, err := TryLock(filepath.Join(t.TempDir(), "missing-dir", ".runner"))
+	require.Error(t, err)
+	require.NotErrorIs(t, err, ErrLocked)
 }