nprasad2077/runner
1
0 Fork 0
mirror of https://gitea.com/gitea/runner.git synced 2026-11-06 23:30:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hotfix: Skip Checkout Regression (#680)

Browse Source 
* Fix: Skip Checkout Regression

* Fix test name

* Add newline to end of checkout push test

* Restore .gitignore from node12 test. Todo: Restore that file after the test

* Format workflow

* Test: Fix path slash direction for windows relative source path

* Add explicit nil test for newRemoteAction

* Regress .secrets during tests

Co-authored-by: Ryan (hackercat) <[email protected]>
This commit is contained in:
Justin GroteandRyan authored and GitHub committed 2021-05-10 15:12:57 +00:00
1 parent aa68181f6b
commit ef0da2ab9e
5 files changed
+19 -12
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

pkg/runner/run_context.go
+5 -1
View File
@@ -579,7 +579,7 @@ func (rc *RunContext) getGithubContext() *githubContext {
}
func (ghc *githubContext) isLocalCheckout(step *model.Step) bool {
if step.Type() != model.StepTypeInvalid {
if step.Type() == model.StepTypeInvalid {
// This will be errored out by the executor later, we need this here to avoid a null panic though
return false
}
@@ -587,6 +587,10 @@ func (ghc *githubContext) isLocalCheckout(step *model.Step) bool {
return false
}
remoteAction := newRemoteAction(step.Uses)
if remoteAction == nil {
// IsCheckout() will nil panic if we dont bail out early
return false
}
if !remoteAction.IsCheckout() {
return false
}