mirror of
https://gitea.com/gitea/runner.git
synced 2026-11-04 22:37:55 +00:00
silverwind
d882311ec6
Removes dead code and redundant logic and consolidates tests, so there is less to read and maintain. No behavior change. 1. **act/runner**: inline single-use wrappers, compile regexes once instead of per call, embed the trampoline as a string, drop the unused legacy result of `parseActionCommand` 2. **act/container**: `sanitizeConfig` and `mergeContainerConfigs` stop returning the configs they already mutate in place, drop never-set option fields and the unused `user` parameter of `ExecWithCmdLine` 3. **act/common and cache server**: drop the unused `Trace`/`Tracef` loggers and the short SHA of `FindGitRevision`, `RegisterJob` releases through `RevokeJob` 4. **daemon, poller and reporter**: one shutdown wait for both poll modes, drop an unreachable fetch timeout branch, guard the reporter's last report time with its existing lock instead of an atomic 5. **build**: drop unused Makefile and release workflow variables, collapse the goreleaser ignore list to the same build targets 6. **tests**: fold near-duplicate tests into tables with shared setup Throughout, hand-rolled logic gives way to `cmp.Or`, `strings.Cut`, `slices` and `min`/`max`. Reviewed-on: https://gitea.com/gitea/runner/pulls/1335 Reviewed-by: bircni <[email protected]> Co-authored-by: silverwind <[email protected]>
69 lines
1.7 KiB
Go
69 lines
1.7 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// Copyright 2020 The nektos/act Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package common
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
)
|
|
|
|
// LineHandler is a callback function for handling a line
|
|
type LineHandler func(line string) bool
|
|
|
|
// Flusher is implemented by writers that buffer a trailing, not-yet-terminated
|
|
// line. Callers should flush once the underlying stream has reached EOF so the
|
|
// final line (when it is not newline-terminated) is not lost.
|
|
type Flusher interface {
|
|
Flush()
|
|
}
|
|
|
|
type lineWriter struct {
|
|
buffer bytes.Buffer
|
|
handlers []LineHandler
|
|
}
|
|
|
|
// NewLineWriter creates a new instance of a line writer
|
|
func NewLineWriter(handlers ...LineHandler) io.Writer {
|
|
return &lineWriter{handlers: handlers}
|
|
}
|
|
|
|
// FlushWriter flushes w if it implements Flusher. It is a no-op otherwise, so
|
|
// callers can flush an io.Writer without knowing its concrete type.
|
|
func FlushWriter(w io.Writer) {
|
|
if f, ok := w.(Flusher); ok {
|
|
f.Flush()
|
|
}
|
|
}
|
|
|
|
func (lw *lineWriter) Write(p []byte) (int, error) {
|
|
for line := range bytes.SplitAfterSeq(p, []byte{'\n'}) {
|
|
_, _ = lw.buffer.Write(line)
|
|
if len(line) > 0 && line[len(line)-1] == '\n' {
|
|
lw.handleLine(lw.buffer.String())
|
|
lw.buffer.Reset()
|
|
}
|
|
}
|
|
return len(p), nil
|
|
}
|
|
|
|
// Flush emits any buffered, not-yet-newline-terminated content as a final line.
|
|
// It is safe to call multiple times; subsequent calls with an empty buffer are
|
|
// no-ops.
|
|
func (lw *lineWriter) Flush() {
|
|
if lw.buffer.Len() == 0 {
|
|
return
|
|
}
|
|
lw.handleLine(lw.buffer.String())
|
|
lw.buffer.Reset()
|
|
}
|
|
|
|
func (lw *lineWriter) handleLine(line string) {
|
|
for _, h := range lw.handlers {
|
|
if !h(line) {
|
|
break
|
|
}
|
|
}
|
|
}
|