mirror of
https://gitea.com/gitea/runner.git
synced 2026-11-04 22:37:55 +00:00
silverwind
d882311ec6
Removes dead code and redundant logic and consolidates tests, so there is less to read and maintain. No behavior change. 1. **act/runner**: inline single-use wrappers, compile regexes once instead of per call, embed the trampoline as a string, drop the unused legacy result of `parseActionCommand` 2. **act/container**: `sanitizeConfig` and `mergeContainerConfigs` stop returning the configs they already mutate in place, drop never-set option fields and the unused `user` parameter of `ExecWithCmdLine` 3. **act/common and cache server**: drop the unused `Trace`/`Tracef` loggers and the short SHA of `FindGitRevision`, `RegisterJob` releases through `RevokeJob` 4. **daemon, poller and reporter**: one shutdown wait for both poll modes, drop an unreachable fetch timeout branch, guard the reporter's last report time with its existing lock instead of an atomic 5. **build**: drop unused Makefile and release workflow variables, collapse the goreleaser ignore list to the same build targets 6. **tests**: fold near-duplicate tests into tables with shared setup Throughout, hand-rolled logic gives way to `cmp.Or`, `strings.Cut`, `slices` and `min`/`max`. Reviewed-on: https://gitea.com/gitea/runner/pulls/1335 Reviewed-by: bircni <[email protected]> Co-authored-by: silverwind <[email protected]>
51 lines
1.1 KiB
Go
51 lines
1.1 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// Copyright 2020 The nektos/act Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package common
|
|
|
|
import (
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestLineWriterBuffersAndFlushesLines(t *testing.T) {
|
|
var lines []string
|
|
lineWriter := NewLineWriter(func(s string) bool {
|
|
lines = append(lines, s)
|
|
return true
|
|
})
|
|
|
|
assert := assert.New(t)
|
|
write := func(s string) {
|
|
n, err := lineWriter.Write([]byte(s))
|
|
require.NoError(t, err)
|
|
assert.Equal(len(s), n, s)
|
|
}
|
|
|
|
write("")
|
|
write("hello")
|
|
write(" ")
|
|
write("world!!\nextra")
|
|
write(" line\n and another\nlast")
|
|
write(" line\n")
|
|
write("no newline here...")
|
|
|
|
expected := []string{"hello world!!\n", "extra line\n", " and another\n", "last line\n"}
|
|
assert.Equal(expected, lines)
|
|
|
|
FlushWriter(lineWriter)
|
|
expected = append(expected, "no newline here...")
|
|
assert.Equal(expected, lines)
|
|
|
|
FlushWriter(lineWriter)
|
|
assert.Equal(expected, lines)
|
|
}
|
|
|
|
func TestFlushWriterIgnoresNonFlusher(t *testing.T) {
|
|
assert.NotPanics(t, func() { FlushWriter(io.Discard) })
|
|
}
|