mirror of
https://gitea.com/gitea/runner.git
synced 2026-11-04 22:37:55 +00:00
silverwind
dcba546cb3
The intermittent Windows test crashes came from step errors formatting a nil `rc.Run`. `fmt` recovers the nil dereference, but on CPUs with AMX the recovered fault overflows into the heap (https://github.com/golang/go/issues/81238). The errors now name the job, and the Windows test VM hides AMX and runs on UTC, so cached boots no longer jump back 8 hours mid-test. Windows commands now start suspended and resume once they are in their job objects, so no child escapes them. That drops the process scan reading other processes' memory and the last `unsafe` code, which `depguard` now denies. Step processes outlive a crashed runner, and commands are no longer looked up in the runner's working directory, both as with GitHub's runner. Like GitHub's runner, host jobs on Linux and macOS now end the processes carrying the job's `RUNNER_TRACKING_ID`, and image pulls and Dockerfile action builds are retried. Reviewed-on: https://gitea.com/gitea/runner/pulls/1376 Reviewed-by: bircni <[email protected]> Co-authored-by: silverwind <[email protected]>
91 lines
2.2 KiB
Go
91 lines
2.2 KiB
Go
//nolint:goheader // pre-existing issue from nektos/act
|
|
// Copyright 2010 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package lookpath
|
|
|
|
import (
|
|
"errors"
|
|
"io/fs"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
)
|
|
|
|
// ErrNotFound is the error resulting if a path search failed to find an executable file.
|
|
var ErrNotFound = errors.New("executable file not found in %PATH%")
|
|
|
|
func chkStat(file string) error {
|
|
d, err := os.Stat(file)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if d.IsDir() {
|
|
return fs.ErrPermission
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func hasExt(file string) bool {
|
|
return strings.LastIndex(file, ".") > strings.LastIndexAny(file, `:\/`)
|
|
}
|
|
|
|
func findExecutable(file string, exts []string) (string, error) {
|
|
if len(exts) == 0 {
|
|
return file, chkStat(file)
|
|
}
|
|
if hasExt(file) && chkStat(file) == nil {
|
|
return file, nil
|
|
}
|
|
for _, e := range exts {
|
|
if f := file + e; chkStat(f) == nil {
|
|
return f, nil
|
|
}
|
|
}
|
|
return "", fs.ErrNotExist
|
|
}
|
|
|
|
// LookPath searches for an executable named file in the
|
|
// directories named by the PATH environment variable.
|
|
// If file contains a slash, it is tried directly and the PATH is not consulted.
|
|
// LookPath also uses PATHEXT environment variable to match
|
|
// a suitable candidate.
|
|
// The result may be an absolute path or a path relative to the current directory.
|
|
func LookPath2(file string, env map[string]string) (string, error) {
|
|
return lookPathWindows(file, env, lookPath)
|
|
}
|
|
|
|
func lookPath(file string, env map[string]string) (string, error) {
|
|
var exts []string
|
|
x := getenv(env, `PATHEXT`)
|
|
if x != "" {
|
|
for e := range strings.SplitSeq(strings.ToLower(x), `;`) {
|
|
if e == "" {
|
|
continue
|
|
}
|
|
if e[0] != '.' {
|
|
e = "." + e
|
|
}
|
|
exts = append(exts, e)
|
|
}
|
|
} else {
|
|
exts = []string{".com", ".exe", ".bat", ".cmd"}
|
|
}
|
|
|
|
if strings.ContainsAny(file, `:\/`) {
|
|
if f, err := findExecutable(file, exts); err == nil {
|
|
return f, nil
|
|
} else {
|
|
return "", &Error{file, err}
|
|
}
|
|
}
|
|
path := getenv(env, "path")
|
|
for _, dir := range filepath.SplitList(path) {
|
|
if f, err := findExecutable(filepath.Join(dir, file), exts); err == nil {
|
|
return f, nil
|
|
}
|
|
}
|
|
return "", &Error{file, ErrNotFound}
|
|
}
|