mirror of
https://gitea.com/gitea/runner.git
synced 2026-11-05 23:05:45 +00:00
silverwind
30e600d8f6
Reduce redundant fixture setup, Git subprocesses, and large data copies while preserving test coverage. Local macOS measurements against main: | Measurement | Before | After | | --- | ---: | ---: | | Git package time, median of 3 alternating runs | 4.09 s | 3.48 s (-15%) | | Allocations across 18 action-bundle cases | 489 MiB | 251 MiB (-49%) | | Traced Git starts per checkout table run | 234 | 175 | Reviewed-on: https://gitea.com/gitea/runner/pulls/1386 Reviewed-by: bircni <[email protected]>
62 lines
1.6 KiB
Go
62 lines
1.6 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package process
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"golang.org/x/sys/windows"
|
|
)
|
|
|
|
func processAlive(pid int) bool {
|
|
h, err := windows.OpenProcess(windows.PROCESS_QUERY_LIMITED_INFORMATION, false, uint32(pid))
|
|
if err != nil {
|
|
return false
|
|
}
|
|
defer func() { _ = windows.CloseHandle(h) }()
|
|
var code uint32
|
|
if err := windows.GetExitCodeProcess(h, &code); err != nil {
|
|
return false
|
|
}
|
|
const stillActive = 259
|
|
return code == stillActive
|
|
}
|
|
|
|
func newProcessExitWaiter(t *testing.T, pids ...int) func() {
|
|
t.Helper()
|
|
handles := make([]windows.Handle, 0, len(pids))
|
|
for _, pid := range pids {
|
|
handle, err := windows.OpenProcess(windows.SYNCHRONIZE, false, uint32(pid))
|
|
require.NoError(t, err)
|
|
t.Cleanup(func() { require.NoError(t, windows.CloseHandle(handle)) })
|
|
handles = append(handles, handle)
|
|
}
|
|
return func() {
|
|
t.Helper()
|
|
result, err := windows.WaitForMultipleObjects(handles, true, 20000)
|
|
require.NoError(t, err)
|
|
require.EqualValues(t, windows.WAIT_OBJECT_0, result, "processes should exit: %v", pids)
|
|
}
|
|
}
|
|
|
|
func TestKillerKillsTree(t *testing.T) {
|
|
cmd, ready := newTestProcess(t, "parent", false)
|
|
require.NoError(t, cmd.Start())
|
|
|
|
killer, err := NewKiller(cmd.Process)
|
|
require.NoError(t, err)
|
|
t.Cleanup(func() {
|
|
_ = killer.Kill()
|
|
_ = killer.Close()
|
|
})
|
|
|
|
childPID := ready()
|
|
require.True(t, processAlive(childPID), "child process should start")
|
|
|
|
waitForExit := newProcessExitWaiter(t, cmd.Process.Pid, childPID)
|
|
require.NoError(t, killer.Kill())
|
|
waitForExit()
|
|
}
|