mirror of
https://gitea.com/gitea/runner.git
synced 2026-11-04 22:37:55 +00:00
Contains a number of small bug fixes where jobs behaved differently from GitHub or failed silently.
1. Hooks fail on a refused `::set-env::` or `::add-path::` and no longer inherit the last step's identity
1. Docker build, exec and wait errors are returned instead of swallowed, token-only registry credentials work, logs of `--tty` services decode
1. Env files split lines like GitHub on each OS, so a carriage return is kept on Linux and CRLF ends a line on Windows, empty heredoc names or delimiters are rejected
1. Post steps run after their pre step even when main was skipped, composites see undeclared inputs, `runs.args` wins without `with.args` being parsed
1. Docker actions skip evaluating defaults of inputs given in `with` and read `entryPoint` and `args` in any case, a lowercase `dockerfile` is found, undeclared inputs get GitHub's warning
1. A user-set `CI` is kept, `GITHUB_REPOSITORY_ID` and the other missing `GITHUB_*` variables are exported
1. `timeout-minutes` can read the step's own `env`, a step-level `ACTIONS_ALLOW_UNSECURE_COMMANDS: false` beats a job-level `true` while the runner's own opt-in still wins, `pwsh` quotes the script path
1. A step `env:` given as one expression such as `${{ fromJSON(matrix.env) }}` is applied, `hashFiles` fails with GitHub's messages on script errors and after 120 seconds, a job image without node still gets an empty hash
1. A step whose command files cannot be reset fails instead of importing stale ones, a timeout between steps fails the job instead of reporting success
1. One named volume can be mounted at several paths, host-mode PTY steps keep their last output when they fail, host scratch directories are removed when job setup fails
1. Cancelling a step right after it starts kills its whole process tree
1. Cache prefix restores pick the newest entry created within the same second, also on S3, cache commits with a wrong size are rejected
1. Artifact chunks are written at their offset, download URLs are escaped, listing a run without artifacts no longer crashes
1. Poll backoff reaches `fetch_interval_max`, proxy passwords are masked in more forms, secrets are also masked in step names and in their quoted form in the runner log, a failed final report is logged
1. On Windows hosts a differently cased unsecure-commands opt-in or proxy variable counts, and an early cancel no longer leaks a job object handle
1. Interactive `register` prompts for a missing token and stops on SIGTERM, `exec --list --detect-event` no longer panics without events, `config set` works on `cache.s3` keys
Reviewed-on: https://gitea.com/gitea/runner/pulls/1338
Reviewed-by: bircni <[email protected]>
Co-authored-by: silverwind <[email protected]>
99 lines
3.1 KiB
Go
99 lines
3.1 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// Copyright 2022 The nektos/act Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package container
|
|
|
|
import (
|
|
"archive/tar"
|
|
"bufio"
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"strings"
|
|
|
|
"gitea.com/gitea/runner/act/common"
|
|
|
|
"golang.org/x/text/encoding/unicode"
|
|
"golang.org/x/text/transform"
|
|
)
|
|
|
|
// parseEnvFile reads a GITHUB_ENV style file, splitting lines like GitHub's runner on Windows or elsewhere.
|
|
func parseEnvFile(e Container, srcPath string, env *map[string]string, windows bool) common.Executor {
|
|
localEnv := *env
|
|
return func(ctx context.Context) error {
|
|
envTar, err := e.GetContainerArchive(ctx, srcPath)
|
|
if err != nil {
|
|
return nil
|
|
}
|
|
defer envTar.Close()
|
|
reader := tar.NewReader(envTar)
|
|
_, err = reader.Next()
|
|
if err != nil && err != io.EOF {
|
|
return err
|
|
}
|
|
// Decode by BOM: Windows PowerShell 5.1 redirection writes UTF-16, and some
|
|
// tools emit a UTF-8 BOM. Without a BOM the file is read as UTF-8, as before.
|
|
decoded := transform.NewReader(reader, unicode.BOMOverride(unicode.UTF8.NewDecoder()))
|
|
|
|
s := bufio.NewScanner(decoded)
|
|
// Default 64 KiB max token size is too small for realistic env-file lines; allow up to 16 MiB.
|
|
s.Buffer(make([]byte, 0, 64*1024), 16*1024*1024)
|
|
s.Split(func(data []byte, atEOF bool) (int, []byte, error) {
|
|
advance, token, err := bufio.ScanLines(data, atEOF)
|
|
if token != nil {
|
|
return advance, data[:advance], err
|
|
}
|
|
return advance, token, err
|
|
})
|
|
for s.Scan() {
|
|
line := trimEnvLineEnding(s.Text(), windows)
|
|
// GitHub's runner ignores blank lines
|
|
if strings.TrimSpace(line) == "" {
|
|
continue
|
|
}
|
|
singleLineEnv := strings.Index(line, "=")
|
|
multiLineEnv := strings.Index(line, "<<")
|
|
switch {
|
|
case singleLineEnv != -1 && (multiLineEnv == -1 || singleLineEnv < multiLineEnv):
|
|
localEnv[line[:singleLineEnv]] = line[singleLineEnv+1:]
|
|
case multiLineEnv != -1:
|
|
var multiLineEnvContent []string
|
|
multiLineEnvDelimiter := line[multiLineEnv+2:]
|
|
if multiLineEnv == 0 || multiLineEnvDelimiter == "" {
|
|
return fmt.Errorf("invalid format '%v', name and delimiter must not be empty", line)
|
|
}
|
|
delimiterFound := false
|
|
for s.Scan() {
|
|
content := s.Text()
|
|
if trimEnvLineEnding(content, windows) == multiLineEnvDelimiter {
|
|
delimiterFound = true
|
|
break
|
|
}
|
|
multiLineEnvContent = append(multiLineEnvContent, content)
|
|
}
|
|
if err := s.Err(); err != nil {
|
|
return fmt.Errorf("reading env file: %w", err)
|
|
}
|
|
if !delimiterFound {
|
|
return fmt.Errorf("invalid format delimiter '%v' not found before end of file", multiLineEnvDelimiter)
|
|
}
|
|
localEnv[line[:multiLineEnv]] = trimEnvLineEnding(strings.Join(multiLineEnvContent, ""), windows)
|
|
default:
|
|
return fmt.Errorf("invalid format '%v', expected a line with '=' or '<<'", line)
|
|
}
|
|
}
|
|
if err := s.Err(); err != nil {
|
|
return fmt.Errorf("reading env file: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func trimEnvLineEnding(line string, windows bool) string {
|
|
if windows && strings.HasSuffix(line, "\r\n") {
|
|
return line[:len(line)-2]
|
|
}
|
|
return strings.TrimSuffix(line, "\n")
|
|
}
|