nprasad2077/gopeed
1
0 Fork 0
mirror of https://github.com/GopeedLab/gopeed.git synced 2026-11-05 16:15:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): keep mobile create task actions in safe area (#1504)

Browse Source
This commit is contained in:
Levi authored and GitHub committed 2026-09-12 09:28:04 +08:00
1 parent ff8f61423e
commit 091e7b8936
2 files changed
+26 -19
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ui/flutter/lib/features/tasks/presentation/pages/create_task_window_page.dart
+21 -18
View File
@@ -687,24 +687,27 @@ class _CreateTaskWindowPageState extends ConsumerState<CreateTaskWindowPage> {
),
),
),
Container(
padding: const EdgeInsets.fromLTRB(24, 12, 24, 20),
decoration: BoxDecoration(
border: Border(top: BorderSide(color: palette.border)),
),
child: Row(
mainAxisAlignment: MainAxisAlignment.center,
children: [
CreateTaskActionButtons(
submitting: _creating,
onCancel: _closeWindow,
onSubmit: _confirm,
cancelLabel: context.l10n.cancel,
submitLabel: context.l10n.confirm,
cancelButtonKey: const ValueKey('create-task-cancel-button'),
submitButtonKey: const ValueKey('create-task-confirm-button'),
),
],
SafeArea(
top: false,
child: Container(
padding: const EdgeInsets.fromLTRB(24, 12, 24, 20),
decoration: BoxDecoration(
border: Border(top: BorderSide(color: palette.border)),
),
child: Row(
mainAxisAlignment: MainAxisAlignment.center,
children: [
CreateTaskActionButtons(
submitting: _creating,
onCancel: _closeWindow,
onSubmit: _confirm,
cancelLabel: context.l10n.cancel,
submitLabel: context.l10n.confirm,
cancelButtonKey: const ValueKey('create-task-cancel-button'),
submitButtonKey: const ValueKey('create-task-confirm-button'),
),
],
),
),
),
],
ui/flutter/test/features/tasks/presentation/create_task_window_page_test.dart
+5 -1
View File
@@ -165,7 +165,7 @@ void main() {
}
});
testWidgets('mobile create task page starts below the system status bar', (WidgetTester tester) async {
testWidgets('mobile create task page stays within the system safe areas', (WidgetTester tester) async {
debugDefaultTargetPlatformOverride = TargetPlatform.android;
tester.view.physicalSize = const Size(700, 760);
tester.view.devicePixelRatio = 1;
@@ -193,6 +193,10 @@ void main() {
final contentPadding = tester.widget<Padding>(find.byKey(const ValueKey('create-task-safe-content')));
expect((contentPadding.padding as EdgeInsets).top, 32);
expect(
tester.getBottomRight(find.byKey(const ValueKey('create-task-confirm-button'))).dy,
lessThanOrEqualTo(tester.view.physicalSize.height / tester.view.devicePixelRatio - 24),
);
} finally {
debugDefaultTargetPlatformOverride = null;
}