mirror of
https://gitea.com/gitea/runner.git
synced 2026-11-12 19:03:45 +00:00
silverwind
645b17de72
Closes differences from GitHub's runner that common workflows hit:
- `ACTIONS_STEP_DEBUG` set as a repository variable enables debug output as on GitHub, where a secret of the same name still takes precedence. `runner.debug` and `RUNNER_DEBUG` are now also set inside composite actions, which lost the secret.
- `github.env` and `github.path` hold the file-command paths instead of being empty, so `echo "A=1" >> "${{ github.env }}"` works.
- Remote composite actions only get a pre stage when they nest actions. That stage evaluated `with:` before earlier steps ran, so an input like `${{ fromJSON(steps.meta.outputs.json).v }}` failed the job.
- `ports` on a job container are published, they were ignored while service ports worked.
- Dockerfile action build output reaches the job log. It was logged at debug and dropped, so a failing `RUN` showed only the final error.
- Local Docker actions honor their `.dockerignore`, as `docker build` does.
- Cancelling or timing out a host-mode step sends SIGINT, then SIGTERM after 7.5 seconds and SIGKILL after 2.5 more, as GitHub's runner does, so `trap` handlers and shutdown hooks run.
- `.sh` job hooks fall back to `sh` where bash is missing, and `.ps1` hooks to `powershell` where pwsh is missing, as on GitHub.
_Written by Claude (Opus 5.5)._
Reviewed-on: https://gitea.com/gitea/runner/pulls/1413
Reviewed-by: bircni <[email protected]>
Co-authored-by: silverwind <[email protected]>
32 lines
800 B
Go
32 lines
800 B
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
//go:build plan9
|
|
|
|
package process
|
|
|
|
import "os"
|
|
|
|
// Killer falls back to single-process termination on platforms without a
|
|
// process-group / Job Object tree-kill. The Job Object (Windows) and process
|
|
// group (Unix) based tree-kills live in killer_windows.go / killer_unix.go;
|
|
// here we just kill the direct child, matching the previous default behaviour.
|
|
type Killer struct {
|
|
p *os.Process
|
|
}
|
|
|
|
func NewKiller(p *os.Process) (*Killer, error) {
|
|
return &Killer{p: p}, nil
|
|
}
|
|
|
|
func (k *Killer) Kill() error {
|
|
if k == nil || k.p == nil {
|
|
return nil
|
|
}
|
|
return k.p.Kill()
|
|
}
|
|
|
|
func (k *Killer) cancel(_process *os.Process, _graceful bool) error { return k.Kill() }
|
|
|
|
func (k *Killer) Close() error { return nil }
|